-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: avoid OOB flow in read_gbq and to_gbq #46312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The console-based copy-paste-a-token flow has been deprecated. See: https://developers.googleblog.com/2022/02/making-oauth-flows-safer.html?m=1#disallowed-oob
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, some doc comments, pls merge master and ping on green
doc/source/whatsnew/v1.5.0.rst
Outdated
``auth_local_webserver = False`` `"out of band" (copy-paste) flow | ||
<https://developers.googleblog.com/2022/02/making-oauth-flows-safer.html?m=1#disallowed-oob>`_. | ||
The ``auth_local_webserver = False`` option is planned to stop working in | ||
October 2022. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add this PR number (see other entries for how)
@@ -29,7 +29,7 @@ def read_gbq( | |||
index_col: str | None = None, | |||
col_order: list[str] | None = None, | |||
reauth: bool = False, | |||
auth_local_webserver: bool = False, | |||
auth_local_webserver: bool = True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @tswast ! |
The console-based copy-paste-a-token flow has been deprecated. See:
https://developers.googleblog.com/2022/02/making-oauth-flows-safer.html?m=1#disallowed-oob
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.