CLN/DOC: fix test_register_entrypoint #46302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
commented
Mar 10, 2022
| # GH-28163 | ||
| module = types.ModuleType("pandas_plot_backend") | ||
| sys.modules["pandas_plot_backend"] = module |
There was a problem hiding this comment.
pandas_plot_backend in sys.modules was leaked into other tests
graingert
commented
Mar 10, 2022
| @td.skip_if_no_mpl | ||
| def test_register_entrypoint(restore_backend): | ||
|
|
||
| dist = pkg_resources.get_distribution("pandas") |
There was a problem hiding this comment.
this test was invalid because the underlying code uses importlib.metadata and not pkg_resources - so the pkg_resources.get_entry_map monkeypatch was unused.
however it passed because the entrypoint name matched the module name and so the code fell back to a regular import
graingert
force-pushed
the
cleanup-pkg-resources-references
branch
2 times, most recently
from
881d1eb to
29e07aa
Compare
graingert
commented
Mar 10, 2022
| @@ -111,22 +116,49 @@ class BackendLoading: | |||
| warmup_time = 0 | |||
|
|
|||
| def setup(self): | |||
| dist = pkg_resources.get_distribution("pandas") | |||
There was a problem hiding this comment.
this test was invalid because the underlying code uses importlib.metadata and not pkg_resources - so this pkg_resources.get_entry_map monkeypatch was unused.
It only passed because _get_plot_backend falls back to importlib.import_module
graingert
changed the title
by cleaning up all outdated references to pkg_resources
graingert
force-pushed
the
cleanup-pkg-resources-references
branch
from
29e07aa to
80715e4
Compare
graingert
changed the title
mroeschke
added
Testing
mroeschke
approved these changes
Mar 11, 2022
|
thanks @graingert very nice |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and cleanup tests eg #27517
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.