Skip to content

REF: simplify reindexing in _align_series() #46266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

johannes-mueller
Copy link
Contributor

Follow-up to #46058

@johannes-mueller johannes-mueller force-pushed the refactor/align-reindexing branch 2 times, most recently from 2850933 to 25c8b40 Compare March 9, 2022 08:17
@johannes-mueller johannes-mueller marked this pull request as ready for review March 9, 2022 09:40
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you adress #46058 (comment) too?

@johannes-mueller
Copy link
Contributor Author

Could you adress #46058 (comment) too?

That's what I intended to address, actually. No more self.values in the new version.

@phofl
Copy link
Member

phofl commented Mar 10, 2022

Sorry, should have looked closer. Forget what I‘ve said

@johannes-mueller johannes-mueller force-pushed the refactor/align-reindexing branch from 25c8b40 to aec76fc Compare March 10, 2022 19:48
@mroeschke mroeschke added the Refactor Internal refactoring of code label Mar 11, 2022
@mroeschke mroeschke added this to the 1.5 milestone Mar 11, 2022
@jreback jreback merged commit 6a4957d into pandas-dev:main Mar 11, 2022
@jreback
Copy link
Contributor

jreback commented Mar 11, 2022

thanks @johannes-mueller

yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Internal refactoring of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants