Skip to content

REF: use standard patterns in tslibs #46259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 10, 2022
Merged

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Some cleanups I noticed while implementing #46246.

@mroeschke mroeschke added Refactor Internal refactoring of code Timezones Timezone data dtype labels Mar 8, 2022
@mroeschke mroeschke added this to the 1.5 milestone Mar 8, 2022
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbrockmendel
Copy link
Member Author

@jreback gentle ping, several follow-ups on deck

@mroeschke mroeschke merged commit a6958fe into pandas-dev:main Mar 10, 2022
@mroeschke
Copy link
Member

Thanks @jbrockmendel. Follow ups can be made as needed

@jbrockmendel jbrockmendel deleted the cln-cy branch March 10, 2022 22:09
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
* REF: use standard patterns in tslibs

* lint fixup

* avoid not-initialized-warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Internal refactoring of code Timezones Timezone data dtype
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants