Skip to content

Bug fix - cannot construct Index of empty tuples #46238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 61 commits into from
Mar 28, 2022
Merged

Bug fix - cannot construct Index of empty tuples #46238

merged 61 commits into from
Mar 28, 2022

Conversation

weikhor
Copy link
Contributor

@weikhor weikhor commented Mar 5, 2022 •
edited
Loading

@weikhor weikhor changed the title cannot construct Index of empty tuples Bug fix - cannot construct Index of empty tuples Mar 5, 2022
@jreback jreback added the Index Related to the Index class or subclasses label Mar 5, 2022
@jreback
Copy link
Contributor

jreback commented Mar 5, 2022

this is failing a lot of tests.

@weikhor
Copy link
Contributor Author

weikhor commented Mar 6, 2022 •
edited
Loading

Yes. I need to fix codes to include all test cases.

@jreback jreback added this to the 1.5 milestone Mar 6, 2022
jreback
jreback requested changes Mar 6, 2022
View reviewed changes
@weikhor weikhor requested a review from jreback March 12, 2022 15:11
@weikhor weikhor requested a review from jreback March 24, 2022 13:06
mroeschke
mroeschke reviewed Mar 24, 2022
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Just needs a whatsnew note

@jreback jreback added this to the 1.5 milestone Mar 25, 2022
@weikhor weikhor requested review from jreback and mroeschke March 25, 2022 01:40
mroeschke
mroeschke reviewed Mar 26, 2022
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment otherwise LGTM

@weikhor weikhor requested a review from mroeschke March 26, 2022 03:49
@weikhor
Copy link
Contributor Author

weikhor commented Mar 26, 2022

Thank for review.

@jreback jreback merged commit 9a2d9ea into pandas-dev:main Mar 28, 2022
@jreback
Copy link
Contributor

jreback commented Mar 28, 2022

thanks @weikhor

yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@yehoshuadimarsky
Bug fix - cannot construct Index of empty tuples (pandas-dev#46238)
655cfeb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Index Related to the Index class or subclasses MultiIndex
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

BUG: cannot construct Index of empty tuples
4 participants
@weikhor @jreback @pep8speaks @mroeschke