-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
PERF: reindex with MultiIndex #46235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -3922,14 +3922,15 @@ def _get_indexer( | |||
elif method == "nearest": | |||
indexer = self._get_nearest_indexer(target, limit, tolerance) | |||
else: | |||
tgt_values = target._get_engine_target() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
very nice @lukemanley |
I think this PR made pyright unhappy, but I honestly don't see how this PR affected _mixins.py:
If the solution is to ignore this warning, you can add edit: pandas/pandas/core/arrays/_mixins.py Line 185 in 3e718e3
|
i think was a prior PR |
Yes, you are right: #46214 If no one beats me, I will create a PR to rename cls to self |
doc/source/whatsnew/v1.5.0.rst
file if fixing a bug or adding a new feature.Avoid unnecessary (and potentially expensive) call to MultiIndex._values. This only matters when MultiIndex._values has not been cached. Existing asv has been updated to test cached and non-cached cases.