Skip to content

DOC: Fix warnings on underline length #46215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2022

Conversation

NickCrews
Copy link
Contributor

@NickCrews NickCrews commented Mar 3, 2022

In the CI run
https://github.com/pandas-dev/pandas/runs/5413504567?check_suite_focus=true
I noticed a few warnings when building the docs such as

/home/runner/miniconda3/envs/pandas-dev/lib/python3.8/site-packages/numpydoc/docscrape.py:434: UserWarning: potentially wrong underline length...
Methods
---------- in
Immutable sequence used for indexing and alignment. The basic object
storing axis labels for all pandas objects. Int64Index is a special case... in the docstring of Int64Index in /home/runner/work/pandas/pandas/pandas/core/indexes/numeric.py.

So these were trivial enough to clean up

  • (simple enough I didn't make one) closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

In https://github.com/pandas-dev/pandas/runs/5413504567?check_suite_focus=true
I noticed a few warnings such as

```
/home/runner/miniconda3/envs/pandas-dev/lib/python3.8/site-packages/numpydoc/docscrape.py:434: UserWarning: potentially wrong underline length...
Methods
---------- in
Immutable sequence used for indexing and alignment. The basic object
storing axis labels for all pandas objects. Int64Index is a special case... in the docstring of Int64Index in /home/runner/work/pandas/pandas/pandas/core/indexes/numeric.py.
```

So these were trivial enough to clean up
@NickCrews
Copy link
Contributor Author

The ASV check failed because of #46193, this change is innocent.

@jreback jreback added the Docs label Mar 4, 2022
@jreback jreback added this to the 1.5 milestone Mar 4, 2022
@jreback jreback merged commit 8e0baa2 into pandas-dev:main Mar 4, 2022
@jreback
Copy link
Contributor

jreback commented Mar 4, 2022

thanks @NickCrews

@NickCrews NickCrews deleted the fix-docs-warnings branch March 4, 2022 03:57
NickCrews added a commit to NickCrews/pandas that referenced this pull request Mar 4, 2022
I missed the other instance of the problem in
pandas-dev#46215.
mroeschke pushed a commit that referenced this pull request Mar 4, 2022
I missed the other instance of the problem in
#46215.
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants