REF: simplify groupby.ops #46196
Merged
REF: simplify groupby.ops #46196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm lots of checks were skipped |
|
hmmph 32bit build is still a PITA. will troubleshoot a bit more and scale back the offending part of necessary. related #46197 should be OK in the interim |
|
looks like the 32bit is segfaulting and that is somehow screwing up the other builds? |
jbrockmendel
force-pushed
the
ref-gbops-ea
branch
from
c32cb38 to
b4cf263
Compare
|
punted on the 32bit thing; greenish |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inching towards refactoring out special-cased EA methods into EA/EADtype methods.
I expect this to need some troubleshooting on the 32bit linux build.