Skip to content

DOC: Clarify groupby.first does not use nulls #46195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 10, 2022

Conversation

NumberPiOso
Copy link
Contributor

@jreback
Copy link
Contributor

jreback commented Mar 2, 2022

great. can you also update .last()?

Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small request, otherwise looks great.

@jreback jreback added this to the 1.5 milestone Mar 5, 2022
@NumberPiOso NumberPiOso force-pushed the docstring-groupby-first branch from e369bbc to 465504f Compare March 8, 2022 20:30
@NumberPiOso NumberPiOso requested a review from rhshadrach March 8, 2022 20:30
@NumberPiOso NumberPiOso force-pushed the docstring-groupby-first branch from 465504f to e4447f7 Compare March 9, 2022 15:21
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach merged commit e139469 into pandas-dev:main Mar 10, 2022
@rhshadrach
Copy link
Member

Thanks @NumberPiOso!

yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: groupby.first/last with nans
3 participants