-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: Clarify groupby.first does not use nulls #46195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rhshadrach
merged 5 commits into
pandas-dev:main
from
NumberPiOso:docstring-groupby-first
Mar 10, 2022
Merged
DOC: Clarify groupby.first does not use nulls #46195
rhshadrach
merged 5 commits into
pandas-dev:main
from
NumberPiOso:docstring-groupby-first
Mar 10, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NumberPiOso
commented
Mar 1, 2022
- closes BUG: groupby.first/last with nans #8427
- All code checks passed.
great. can you also update |
rhshadrach
requested changes
Mar 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small request, otherwise looks great.
rhshadrach
requested changes
Mar 6, 2022
e369bbc
to
465504f
Compare
465504f
to
e4447f7
Compare
rhshadrach
approved these changes
Mar 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks @NumberPiOso! |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.