Skip to content

CLN: rolling step followups #46191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 2, 2022
Merged

CLN: rolling step followups #46191

merged 3 commits into from
Mar 2, 2022

Conversation

mroeschke
Copy link
Member

xref #45765

@mroeschke mroeschke added the Window rolling, ewma, expanding label Mar 1, 2022
@mroeschke mroeschke added this to the 1.5 milestone Mar 1, 2022
@jreback
Copy link
Contributor

jreback commented Mar 1, 2022

@jreback
Copy link
Contributor

jreback commented Mar 1, 2022

cc @rtpsw

@rtpsw
Copy link
Contributor

rtpsw commented Mar 1, 2022

doc string check failing: https://github.com/pandas-dev/pandas/runs/5371271902?check_suite_focus=true

Note that, while trying to reproduce this, I got the following error after pulling main:

$ ./ci/code_checks.sh docstrings
Validate docstrings (GL01, GL02, GL03, GL04, GL05, GL06, GL07, GL09, GL10, SS01, SS02, SS03, SS04, SS05, PR03, PR04, PR05, PR06, PR08, PR09, PR10, EX04, RT01, RT04, RT05, SA02, SA03)
Traceback (most recent call last):
  File "./ci/../scripts/validate_docstrings.py", line 32, in <module>
    from numpydoc.docscrape import get_doc_object
ImportError: cannot import name 'get_doc_object' from 'numpydoc.docscrape' (/mnt/user1/tscontract/venv/lib/python3.8/site-packages/numpydoc/docscrape.py)
Validate docstrings (GL01, GL02, GL03, GL04, GL05, GL06, GL07, GL09, GL10, SS01, SS02, SS03, SS04, SS05, PR03, PR04, PR05, PR06, PR08, PR09, PR10, EX04, RT01, RT04, RT05, SA02, SA03) DONE

I was able to move past this error by changing to numpydoc>=1.2.0 in requirements-dev.txt and pip install -r requirements-dev.txt.

@jreback jreback merged commit 0ccad38 into pandas-dev:main Mar 2, 2022
@mroeschke mroeschke deleted the ref/step branch March 2, 2022 16:19
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Window rolling, ewma, expanding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants