Skip to content

CI/TST: Fix xfail(strict=False) condition #46150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2022
Merged

CI/TST: Fix xfail(strict=False) condition #46150

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4f61ac
CI/TST: Fix xfail(strict=False) condition
mroeschke Feb 25, 2022
0218260
add comment
mroeschke Feb 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions pandas/tests/indexes/test_setops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,11 @@ def test_union_different_types(index_flat, index_flat2, request):
if (
not idx1.is_unique
and not idx2.is_unique
and not idx2.is_monotonic_decreasing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could add a comment pointing back here to the effect of "not idx2.is_monotonic_decreasing covers most cases but is too strict"

and idx1.dtype.kind == "i"
and idx2.dtype.kind == "b"
) or (
not idx2.is_unique
and not idx1.is_unique
and not idx1.is_monotonic_decreasing
and idx2.dtype.kind == "i"
and idx1.dtype.kind == "b"
):
Expand Down