Skip to content

REF: isinstance(x, int) -> is_integer(x) #46119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2022
Merged

REF: isinstance(x, int) -> is_integer(x) #46119

merged 1 commit into from
Feb 26, 2022

Conversation

attack68
Copy link
Contributor

No description provided.

mroeschke
mroeschke approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice LGTM

@mroeschke mroeschke added the Refactor Internal refactoring of code label Feb 22, 2022
@mroeschke mroeschke added this to the 1.5 milestone Feb 22, 2022
@jbrockmendel
Copy link
Member

Is there user-facing in a way that could represent a bugfix?

@attack68
Copy link
Contributor Author

Is there user-facing in a way that could represent a bugfix?

I can't remember why this came up, but there was a reason. It might have been when formatting new Int64 with thousands separator, but the Int64 didn't get detected by int so didn't show the separator. This fix was recommended to me in another PR recently.

@jreback
Copy link
Contributor

jreback commented Feb 26, 2022

you could actually test this (e.g. pass in np.int64 intead of ints for some args), but nbd.

@jreback jreback merged commit 541bbf9 into pandas-dev:main Feb 26, 2022
@attack68 attack68 deleted the styler_is_xx branch March 6, 2022 07:21
@attack68 attack68 mentioned this pull request Mar 16, 2022
Closed
3 tasks
simonjayhawkins added a commit that referenced this pull request Mar 25, 2022
@simonjayhawkins
Revert "is type refactor (#46119)"
066da75 
This reverts commit 541bbf9.
@simonjayhawkins simonjayhawkins mentioned this pull request Mar 25, 2022
Closed
@simonjayhawkins
Copy link
Member

@meeseeksdev backport 1.4.x

@meeseeksmachine meeseeksmachine mentioned this pull request Mar 25, 2022
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Mar 25, 2022
@attack68 @meeseeksmachine
Backport PR pandas-dev#46119: REF: isinstance(x, int) -> is_integer(x)
10680d9
simonjayhawkins added a commit that referenced this pull request Mar 29, 2022
@meeseeksmachine @attack68 @simonjayhawkins
Backport PR #46119: REF: isinstance(x, int) -> is_integer(x) (#46501)
ccdb97e 
Co-authored-by: JHM Darbyshire <[email protected]>
Co-authored-by: Simon Hawkins <[email protected]>
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@attack68 @yehoshuadimarsky
is type refactor (pandas-dev#46119)
57c041d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Refactor Internal refactoring of code
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
5 participants
@attack68 @jbrockmendel @jreback @simonjayhawkins @mroeschke