-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ENH: allow concat of Styler objects #46105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
attack68
commented
Feb 21, 2022
•
edited
Loading
edited
- closes ENH: Add option to display dtypes below column headers #43875
- closes ENH: Add custom descriptors (such as dtype, nunique, etc.) to Styler output #43894
Not sure if this assessment is correct, but this would this be a generic version of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only a very brief look but the same problem as the other PR
this is commingling calculation and display
yes, ok i now see your point. how about I change tack and require a user to pass an already calculated dataframe or Styler object which will be appended to the footer? This would also get around any need to format or style the footer since it would inherit from the passed Styler object? |
@jreback I completely reworked this and managed to get the entire implementation under 20 lines execution code. All calculations are done by the user, they just pass a second styler object. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I'm +1 for this API compared to the previous one
# Conflicts: # pandas/tests/io/formats/style/test_to_latex.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on this too, much better api a few comments