Skip to content

Typeinterval part2 #46098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Feb 27, 2022
Merged

Typeinterval part2 #46098

merged 24 commits into from
Feb 27, 2022

Conversation

Dr-Irv
Copy link
Contributor

@Dr-Irv Dr-Irv commented Feb 21, 2022 •
edited
Loading

Is on top of #46080

I believe the typing for Interval here is correct as it passes the tests created here:
microsoft/python-type-stubs#167

Leaving this as draft status as it requires #46080 to be approved.

Or a decision to go with #44922, in which case we kill #46080 and this one.

@Dr-Irv Dr-Irv added the Typing type annotations, mypy/pyright type checking label Feb 21, 2022
@Dr-Irv Dr-Irv marked this pull request as draft February 21, 2022 17:40
@twoertwein
Copy link
Member

Looks pretty good @Dr-Irv! I'll look at part 1 tomorrow.

@Dr-Irv
Copy link
Contributor Author

Dr-Irv commented Feb 22, 2022

Looks pretty good @Dr-Irv! I'll look at part 1 tomorrow.

Thanks!

@twoertwein twoertwein mentioned this pull request Feb 23, 2022
Closed
@jreback
Copy link
Contributor

jreback commented Feb 26, 2022

other PR merged so pls rebase

@Dr-Irv Dr-Irv marked this pull request as ready for review February 27, 2022 02:17
@Dr-Irv
Copy link
Contributor Author

Dr-Irv commented Feb 27, 2022

other PR merged so pls rebase

all set and all green

@Dr-Irv
Feedback from twoertwein
9e11b8c 
- Use IntervalClosedType
- Consolidate __get__ in LengthDescriptor
- Use tuple instead of Tuple
twoertwein
twoertwein approved these changes Feb 27, 2022
View reviewed changes
Copy link
Member

@twoertwein twoertwein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @Dr-Irv looks go to me!

@jreback jreback added this to the 1.5 milestone Feb 27, 2022
@jreback jreback merged commit 66a5de3 into pandas-dev:main Feb 27, 2022
@jreback
Copy link
Contributor

jreback commented Feb 27, 2022

thanks @Dr-Irv keep em coming!

yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@Dr-Irv @yehoshuadimarsky
Typeinterval part2 (pandas-dev#46098)
5262e47
@Dr-Irv Dr-Irv deleted the typeinterval_part2 branch February 13, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twoertwein twoertwein twoertwein approved these changes

@simonjayhawkins simonjayhawkins Awaiting requested review from simonjayhawkins

Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
3 participants
@Dr-Irv @twoertwein @jreback