CI: pin markupsafe to avoid import error #46054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Feb 18, 2022
| @@ -29,6 +29,7 @@ dependencies: | |||
| - gcsfs=0.6.0 | |||
| - jinja2=2.11 | |||
| - lxml=4.5.0 | |||
| - markupsafe=2.0.1 | |||
There was a problem hiding this comment.
Could you add a note that this is a Jinja dependency not necessarily a pandas one and why it was pinned?
There was a problem hiding this comment.
Done, we can not really add comments inline, because the version sync script can not deal with them. Added it in the optional dependencies header line
mroeschke
approved these changes
Feb 18, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Feb 18, 2022
lithomas1
pushed a commit
that referenced
this pull request
Feb 19, 2022
Co-authored-by: Patrick Hoefler <[email protected]>
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
* CI: pin markupsafe to avoid import error * Add comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets see if this fixes the ci