BUG: read_csv not respecting converter in all cases for index col #46053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Feb 22, 2022
pandas/io/parsers/base_parser.py
Outdated
| @@ -503,7 +505,11 @@ def _agg_index(self, index, try_parse_dates: bool = True) -> Index: | |||
| if isinstance(clean_dtypes, dict) and self.index_names is not None: | |||
| cast_type = clean_dtypes.get(self.index_names[i], None) | |||
|
|
|||
| try_num_bool = not (cast_type and is_string_dtype(cast_type)) | |||
| conv = False | |||
| if isinstance(converters, dict) and self.index_names is not None: | |||
There was a problem hiding this comment.
Could combine with the above check as if self.index_names is not None: first and then the 2 isinstance(arg, dict) checks
There was a problem hiding this comment.
Thx, this looks better, also renamed the variable
|
very nice @phofl |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.