Skip to content

DOC: Minor addition to str.split #46027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 22, 2022
Merged

DOC: Minor addition to str.split #46027

merged 6 commits into from
Feb 22, 2022

Conversation

ChrisAlbertsen
Copy link
Contributor

@ChrisAlbertsen ChrisAlbertsen commented Feb 16, 2022 •
edited
Loading

phofl
phofl reviewed Feb 16, 2022
View reviewed changes
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you maybe add an example?

@ChrisAlbertsen
Copy link
Contributor Author

Could you maybe add an example?

Nice idea.
I tried to add an integer and a boolean to the Series used for the already existing examples.

I'm thinking that it might be preferable to incorporate the method's behaviour in the already existing examples rather than adding new examples to show it off. Or am I wrong in this?

phofl
phofl approved these changes Feb 17, 2022
View reviewed changes
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mroeschke mroeschke added the Docs label Feb 22, 2022
@mroeschke mroeschke added this to the 1.5 milestone Feb 22, 2022
@mroeschke mroeschke merged commit 1c09a5d into pandas-dev:main Feb 22, 2022
@mroeschke
Copy link
Member

Thanks @ChrisAlbertsen

yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@ChrisAlbertsen @yehoshuadimarsky
DOC: Minor addition to str.split (pandas-dev#46027)
d46bf69 
* DOC: Minor addition to str.split

* Make Series uppercase and NaN plural

* example suggestion for method behaviour

* allign Series values in hopes of passing tests

* fixed lowercase Nan typing error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@attack68 attack68 attack68 approved these changes

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

BUG: Series.str.strip() removes numeric and bool values instead of only string whitespace
4 participants
@ChrisAlbertsen @mroeschke @attack68 @phofl