-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
TST: Don't mark all plotting tests as slow #46003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hmm windows builds taking a long time (but succeeding) |
Added some |
hmm this are you sure we should not mark these slow? seems to be increasing the ci times |
That would mean no plotting tests would run on MacOS/Windows builds since we're running IMO testing platform coverage should be more important than CI times since a lot of pandas development is pretty async |
can we run a slow build on those platforms? |
I can follow up by removing |
can you rebase |
can we reduce the matrix a bit to lower the number of total jobs? |
Hmm the current jobs were deemed "important" at some point. If we need to prune jobs, my vote would be to remove the 2 locale jobs first.
|
We could also remove testing pyarrow 6. I think that would reduce 3 builds. |
for pyarrow oldest and newest are fine (are we testing more)? |
We're testing 1.0.1 (min), 5, 6, 7 right now. (we're not testing 2 or 3 since we've observed read_csv timeouts with those versions) IIRC @jorisvandenbossche aimed to test more pyarrow versions since some pandas-pyarrow functionality is only available in certain versions. |
ok then dropping 6 is fine as 5,7 are testing |
Ideally we should be more targeted regarding a slow test