Skip to content

TST: Don't mark all plotting tests as slow #46003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Feb 27, 2022

Conversation

mroeschke
Copy link
Member

Ideally we should be more targeted regarding a slow test

@mroeschke mroeschke added the Testing pandas testing functions or related to the test suite label Feb 15, 2022
@mroeschke mroeschke marked this pull request as draft February 15, 2022 19:32
@jreback jreback added this to the 1.5 milestone Feb 16, 2022
@jreback
Copy link
Contributor

jreback commented Feb 16, 2022

hmm windows builds taking a long time (but succeeding)

@mroeschke mroeschke marked this pull request as ready for review February 16, 2022 16:13
@mroeschke
Copy link
Member Author

hmm windows builds taking a long time (but succeeding)

Added some @pytest.mark.slow to some of the plotting tests (ones in the top 30 slowest)

@jreback
Copy link
Contributor

jreback commented Feb 17, 2022

hmm this are you sure we should not mark these slow? seems to be increasing the ci times

@mroeschke
Copy link
Member Author

hmm this are you sure we should not mark these slow? seems to be increasing the ci times

That would mean no plotting tests would run on MacOS/Windows builds since we're running not slow. I was able to discover a PY3.10 entrypoints bug since we weren't running these tests before

IMO testing platform coverage should be more important than CI times since a lot of pandas development is pretty async

@jreback
Copy link
Contributor

jreback commented Feb 18, 2022

can we run a slow build on those platforms?

@mroeschke
Copy link
Member Author

can we run a slow build on those platforms?

I can follow up by removing not slow from these builds

@jreback
Copy link
Contributor

jreback commented Feb 26, 2022

can you rebase

@jreback jreback merged commit 63616a6 into pandas-dev:main Feb 27, 2022
@jreback
Copy link
Contributor

jreback commented Feb 27, 2022

can we reduce the matrix a bit to lower the number of total jobs?

@mroeschke mroeschke deleted the tests/plotting branch February 27, 2022 18:03
@mroeschke
Copy link
Member Author

Hmm the current jobs were deemed "important" at some point. If we need to prune jobs, my vote would be to remove the 2 locale jobs first.

  • Runs a lot of redundant tests
  • Relevant tests cannot be targeted
  • Encourage users to locally tests, patches accepted, but not practical to test (every locale) in our CI. Similar to our 32 bit testing eventually: BLD: remove support for 32 bit #44453

@mroeschke
Copy link
Member Author

We could also remove testing pyarrow 6. I think that would reduce 3 builds.

@jreback
Copy link
Contributor

jreback commented Feb 27, 2022

for pyarrow oldest and newest are fine (are we testing more)?

@mroeschke
Copy link
Member Author

We're testing 1.0.1 (min), 5, 6, 7 right now. (we're not testing 2 or 3 since we've observed read_csv timeouts with those versions)

IIRC @jorisvandenbossche aimed to test more pyarrow versions since some pandas-pyarrow functionality is only available in certain versions.

@jreback
Copy link
Contributor

jreback commented Feb 28, 2022

ok then dropping 6 is fine as 5,7 are testing

yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants