Skip to content

Skip converts na values to strings #45971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

weikhor
Copy link
Contributor

@weikhor weikhor commented Feb 13, 2022

@pep8speaks
Copy link

pep8speaks commented Feb 13, 2022

Hello @weikhor! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-02-14 11:20:26 UTC

"array",
[(["foo", "bar", pd.NA]), (["foo", "bar", np.NaN]), (["foo", "bar", None])],
)
def test_skip_convert_nan_values_to_strings(self, array):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to remove self, this is not in a class

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this broke other tests

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to fix the other tests

@weikhor
Copy link
Contributor Author

weikhor commented Feb 15, 2022

@phofl Hi This issue is already closed. I close this PR. Thank for review.

@weikhor weikhor closed this Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: astype("str") converts NA values to strings
3 participants