-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Skip converts na values to strings #45971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip converts na values to strings #45971
Conversation
pandas/tests/dtypes/test_dtypes.py
Outdated
"array", | ||
[(["foo", "bar", pd.NA]), (["foo", "bar", np.NaN]), (["foo", "bar", None])], | ||
) | ||
def test_skip_convert_nan_values_to_strings(self, array): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to remove self, this is not in a class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also this broke other tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to fix the other tests
@phofl Hi This issue is already closed. I close this PR. Thank for review. |
astype("str")
converts NA values to strings #44156doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.