-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: How to use storage_option param here to integrate with GCP bucket? #45928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @MarcoGorelli, I altered a few files, but there are still a few that offer a brief description of the storage options, as shown below. pandas/pandas/io/formats/xml.py Lines 85 to 87 in c24a3c8
pandas/pandas/io/excel/_xlrd.py Lines 20 to 21 in c24a3c8
pandas/pandas/io/excel/_pyxlsb.py Lines 28 to 29 in c24a3c8
pandas/pandas/io/excel/_openpyxl.py Lines 541 to 542 in c24a3c8
pandas/pandas/io/excel/_odfreader.py Lines 26 to 27 in c24a3c8
Lines 101 to 103 in c24a3c8
|
If possible, it might be great to share the doc-strings between all of these methods. I think we already have shared docs for from pandas.util._decorators import doc
from pandas.core.shared_docs import _shared_docs
@doc(storage_options=_shared_docs["storage_options"])
def some_function():
"""
{storage_options}
""" |
I shared the doc-strings over all of the methods, with the exception of the _base file, which isn't a function. pandas/pandas/io/excel/_base.py Lines 275 to 283 in 0a7507d
|
Hello, @twoertwein. Could you please assist me in determining what I am doing incorrectly? |
I think you can replace the section with pandas/pandas/io/excel/_base.py Line 425 in 0a7507d
|
What are you having trouble with? Some tests sometimes randomly fail, the faillures do not seem related to your changes. |
Thank you : ) |
Hello, @twoertwein. Please take a look at the adjustments I made. |
Hey @purna135 - did you try building this locally? I think it'd be helpful if you could post screenshots of the amended docstrings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @purna135! Let's wait for the CI to finish but otherwise looks good to me!
Should I share a screencap of the part where I replaced |
Thank you so much for your support and guidance, @twoertwein; as a newbie, it was extremely helpful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @purna135 , and thanks @twoertwein for reviewing!
…t? (pandas-dev#45928) * added storage_options description * shared the doc-strings between all the methods * shared the doc-strings between all the methods * shared the doc-strings between all the methods * replaced {storage_options} in _base file * replaced {storage_options} in _base file * fixed unescaped braces
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.