DEPR: null_color since color used everywhere else
#45907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
Deprecate
|
no objections, prob this is showing a warning in another test |
mroeschke
reviewed
Feb 22, 2022
mroeschke
reviewed
Feb 23, 2022
mroeschke
approved these changes
Feb 25, 2022
jreback
requested changes
Feb 26, 2022
pandas/io/formats/style.py
Outdated
| @@ -3133,8 +3144,16 @@ def highlight_null( | |||
| def f(data: DataFrame, props: str) -> np.ndarray: | |||
| return np.where(pd.isna(data).to_numpy(), props, "") | |||
|
|
|||
| if null_color != "red": | |||
There was a problem hiding this comment.
you need to make null_color == lib.no_default here (and then if its not that you can warn)
# Conflicts: # doc/source/whatsnew/v1.5.0.rst
jreback
approved these changes
Mar 3, 2022
4 tasks
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in all the builtin highlighters
coloris used. makes this more consistent.