Skip to content

DOC: examples for Styler.pipe #45880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 9, 2022
Merged

DOC: examples for Styler.pipe #45880

merged 5 commits into from
Feb 9, 2022

Conversation

attack68
Copy link
Contributor

@attack68 attack68 commented Feb 8, 2022

Addresses a recent issue raised in #45686

Screen Shot 2022-02-08 at 19 18 03
Screen Shot 2022-02-08 at 19 18 10

mroeschke
mroeschke reviewed Feb 8, 2022
View reviewed changes
pandas/io/formats/style.py Outdated
**Advanced Use**

Sometimes it may be necessary to pre-define styling functions, but in the case
where those functions rely on the styler, or data, context. Since
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: styler, or data, context -> styler, data, or context

mroeschke
mroeschke reviewed Feb 8, 2022
View reviewed changes
pandas/io/formats/style.py Outdated
.. figure:: ../../_static/style/df_pipe.png
**Common Use**

The most common usage pattern may be to pre-define styling operations which
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: The most common usage pattern may be -> A common usage pattern is

mroeschke
mroeschke reviewed Feb 8, 2022
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments otherwise LGTM.

Also off topic question, the docstring examples could (in theory) eventually generate different results from the pngs if future changes are made right?

@attack68
Copy link
Contributor Author

attack68 commented Feb 8, 2022

Some small comments otherwise LGTM.

Also off topic question, the docstring examples could (in theory) eventually generate different results from the pngs if future changes are made right?

yes they could, not sure how to get around this though given this is a visualisation device that is better shown?

@mroeschke
Copy link
Member

Some small comments otherwise LGTM.
Also off topic question, the docstring examples could (in theory) eventually generate different results from the pngs if future changes are made right?

yes they could, not sure how to get around this though given this is a visualisation device that is better shown?

Just curious. Agreed pngs are the better visualization method for these examples.

@mroeschke mroeschke added this to the 1.5 milestone Feb 8, 2022
@mroeschke mroeschke added Docs Styler conditional formatting using DataFrame.style labels Feb 8, 2022
@jreback jreback merged commit 82b6175 into pandas-dev:main Feb 9, 2022
@jreback
Copy link
Contributor

jreback commented Feb 9, 2022

nice @attack68

should this close the original issue?

@attack68 attack68 deleted the pipe_example branch February 9, 2022 07:58
phofl pushed a commit to phofl/pandas that referenced this pull request Feb 14, 2022
@attack68 @phofl
DOC: examples for Styler.pipe (pandas-dev#45880)
d863bec
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@attack68 @yehoshuadimarsky
DOC: examples for Styler.pipe (pandas-dev#45880)
0b21cf0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Docs Styler conditional formatting using DataFrame.style
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
3 participants
@attack68 @mroeschke @jreback