Backport PR #45453 on branch 1.4.x (REF: move np_can_hold_element to mgr method) #45873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
added
Refactor
|
not yet changed milestone on #45453 pending outcome of discussion here |
|
No objections here (assuming CI failures are unrelated) |
ok. let's merge this. I'll assume ci failures are unrelated for now. 1.4.1 release is scheduled for the end of the week, so will need to see a green again before then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport PR #45453
#45744 includes a partial backport of #45453. xref #45744 (comment)
This PR is for completeness or alternatively we could remove the parts of #45453 included in #45744 added in 0464ea8 from 1.4.x
cc @jbrockmendel