Skip to content

Test series replace different numpy int #45797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Feb 5, 2022
Merged

Test series replace different numpy int #45797

merged 20 commits into from
Feb 5, 2022

Conversation

weikhor
Copy link
Contributor

@weikhor weikhor commented Feb 3, 2022

@weikhor weikhor closed this Feb 3, 2022
@weikhor weikhor reopened this Feb 3, 2022
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in the other pr, please parametrize over the different numpy dtypes

Also please do not close the old prs and open new ones. Just continue here until it is ready

@jreback jreback added Dtype Conversions Unexpected or buggy dtype conversions Testing pandas testing functions or related to the test suite labels Feb 4, 2022
Change series dtype to any_int_numpy_dtype
Copy link
Contributor Author

@weikhor weikhor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change series dtype to any_int_numpy_dtype

@jreback jreback added this to the 1.5 milestone Feb 5, 2022
@jreback jreback merged commit 8c7fa53 into pandas-dev:main Feb 5, 2022
@jreback
Copy link
Contributor

jreback commented Feb 5, 2022

thanks @weikhor very nice.

would take a follow up PR extending this test to use the extension dtypes as well (as not sure if we have full test coverage here in a similar manner)

@weikhor weikhor deleted the test-series-replace-different-numpy-int branch February 6, 2022 03:21
phofl pushed a commit to phofl/pandas that referenced this pull request Feb 14, 2022
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dtype Conversions Unexpected or buggy dtype conversions Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: "replace" does not work with different numpy-int types even when values are the same
3 participants