-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Test series replace different numpy int #45797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test series replace different numpy int #45797
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in the other pr, please parametrize over the different numpy dtypes
Also please do not close the old prs and open new ones. Just continue here until it is ready
Change series dtype to any_int_numpy_dtype
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change series dtype to any_int_numpy_dtype
thanks @weikhor very nice. would take a follow up PR extending this test to use the extension dtypes as well (as not sure if we have full test coverage here in a similar manner) |
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.