Regression: Loc raising when indexing mi with one level #45785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Indexing
jreback
requested changes
Feb 3, 2022
| @@ -3128,7 +3128,12 @@ def maybe_mi_droplevels(indexer, levels): | |||
| # e.g. test_partial_string_timestamp_multiindex | |||
| return indexer, self[indexer] | |||
|
|
|||
| return indexer, maybe_mi_droplevels(indexer, [level]) | |||
| try: | |||
| result_index = maybe_mi_droplevels(indexer, [level]) | |||
There was a problem hiding this comment.
hmm can we handle this inside?
There was a problem hiding this comment.
oh i c @jbrockmendel moved this. can you document this in the doc-string of maybe_mi_droplevels? (and prob should just move maybe_mi_droplevels) top a non-nested function (ok with these being a followup on main as well).
There was a problem hiding this comment.
Added a note. Would like to move in a separate pr to not backport this
There was a problem hiding this comment.
great, yeah ideally clean in 1.5
jreback
approved these changes
Feb 9, 2022
|
@meeseeksdev backport 1.4.x |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
@phofl if you wouldn't mind push a backport PR |
simonjayhawkins
pushed a commit
to simonjayhawkins/pandas
that referenced
this pull request
Feb 9, 2022
…i with one level
simonjayhawkins
added a commit
that referenced
this pull request
Feb 9, 2022
… level (#45895) Co-authored-by: Patrick Hoefler <[email protected]>
phofl
added a commit
to phofl/pandas
that referenced
this pull request
Feb 14, 2022
|
Thx for the backport @simonjayhawkins |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.locraises with an unclear error (in 1.4) #45779 (Replace xxxx with the Github issue number)doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.@jbrockmendel You moved the error catching logic out of maybe_mi_droplevels. Is this necessary for one of the other code paths?