Regression: Series.loc.setitem raising with all false indexer and series on rhs #45784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Indexing
|
@meeseeksdev backport 1.4.x |
This comment was marked as resolved.
This comment was marked as resolved.
|
thanks @phofl certainly let's open an issue about consistent indexing here with boolean indexers (and PR if you can :->) |
This comment was marked as resolved.
This comment was marked as resolved.
simonjayhawkins
pushed a commit
to simonjayhawkins/pandas
that referenced
this pull request
Feb 7, 2022
…with all false indexer and series on rhs
|
merge conflict due to #45403 |
jreback
pushed a commit
that referenced
this pull request
Feb 7, 2022
…alse indexer and series on rhs (#45859) Co-authored-by: Patrick Hoefler <[email protected]>
phofl
added a commit
to phofl/pandas
that referenced
this pull request
Feb 14, 2022
|
I think the behavior I mentioned above was aligned in #45501 (not 100% sure if that was the cause, but it is consistent now) |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.This is really annoying. We are treating setting to a Series with all False indexer differently than to a DataFrame. Series raises, DataFrame not. Series does not raise, when rhs is a Series itself (only case as far as I can see). We should think about cleaning that up.