-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
REF: Enhance consistency on Styler methods #45780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REF: Enhance consistency on Styler methods #45780
Conversation
can you check this for consistency with other deprecations that include quotes. a) we are probably not consistent b) we could check forth this (maybe) |
@staticdev status of this? |
@jreback from my side it is ready to be merged. |
Co-authored-by: JHM Darbyshire <[email protected]>
@attack68 fine, I commited your suggestion. |
Thanks @staticdev and @attack68 for merging in main one more time. |
* Enhance consistency on Styler hide methods * Docs and checks * Make set_sticky consistent with all other methods * Remove whatsnew * Apply suggestions from code review Co-authored-by: JHM Darbyshire <[email protected]> Co-authored-by: JHM Darbyshire <[email protected]>
doc/source/whatsnew/v1.4.1.rst
file if fixing a bug or adding a new feature. NOT NEEDEDpandas 1.4.0 introduces deprecation of
hide_columns()
andhide_index()
in favor tohide()
. Problem is the messages docstrings, parameters and warning messages pass parameters in different ways making it confusing and non-readable. This PR was created to address that and make all those consistent.