Skip to content

Lose the index before 'na_value' assignment in 'to_numpy' #45775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 5, 2022
Merged

Lose the index before 'na_value' assignment in 'to_numpy' #45775

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
b4f2062
Reset the index before 'na_value' assignment in 'to_numpy'
DamianBarabonkovQC Feb 2, 2022
75af3bd
Slight performance improvement using 'to_numpy' instead of 'reset_index'
DamianBarabonkovQC Feb 2, 2022
2b9e691
Added to whatsnew
DamianBarabonkovQC Feb 2, 2022
4ff0a99
The 'to_numpy' mask supports both pandas and numpy inputs
DamianBarabonkovQC Feb 3, 2022
9e39eee
Added test cases for MultiIndex Series 'to_numpy' in relation to PR #…
DamianBarabonkovQC Feb 8, 2022
d907826
Merge branch 'main' into multiindex_to_numpy
DamianBarabonkovQC Feb 8, 2022
82d0e0c
Merge branch 'main' into multiindex_to_numpy
DamianBarabonkovQC Feb 8, 2022
c73ba48
Changed entry in 'whatsnew' to refer to public facing features rather…
DamianBarabonkovQC Feb 22, 2022
a14c43c
Merge branch 'multiindex_to_numpy' of github.com:DamianBarabonkovQC/p…
DamianBarabonkovQC Feb 22, 2022
7bf18c3
Merge branch 'main' into multiindex_to_numpy
DamianBarabonkovQC Feb 22, 2022
82d64c4
Added 'na_value=None' test case for multiindex series to numpy test
DamianBarabonkovQC Mar 3, 2022
e45ee10
Removed comment related to issue #45774
DamianBarabonkovQC Mar 3, 2022
2daef52
Merge branch 'main' into multiindex_to_numpy
DamianBarabonkovQC Mar 3, 2022
5512d81
Merge branch 'main' into multiindex_to_numpy
DamianBarabonkovQC Mar 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/source/whatsnew/v1.5.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ Missing

MultiIndex
^^^^^^^^^^
-
- Bug in :meth:`IndexOpsMixin.to_numpy` where multiindexed Series could not be converted to numpy arrays when an ``na_value`` was supplied (:issue:`45774`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the note would need to be user facing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by this comment? I do not understand completely what "needs to be user facing" means. Thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jreback . May you please elaborate on your comment.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IndexOpsMixin is private, this is not exposed through the api

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment should be addressed.

-

I/O
Expand Down
2 changes: 1 addition & 1 deletion pandas/core/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,7 +541,7 @@ def to_numpy(
if copy or na_value is not lib.no_default:
result = result.copy()
if na_value is not lib.no_default:
result[self.isna()] = na_value
result[self.isna().to_numpy()] = na_value
return result

@property
Expand Down