Skip to content

Test series replace for different numpy int #45773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

Test series replace for different numpy int #45773

wants to merge 10 commits into from

Conversation

weikhor
Copy link
Contributor

@weikhor weikhor commented Feb 2, 2022

@pep8speaks
Copy link

pep8speaks commented Feb 2, 2022 •
edited
Loading

Hello @weikhor! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-02-02 07:19:47 UTC

phofl
phofl reviewed Feb 2, 2022
View reviewed changes
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please parametrize over the other numpy int dtypes (e.g. np.int8)

@jreback jreback added replace replace method Testing pandas testing functions or related to the test suite labels Feb 3, 2022
@weikhor weikhor closed this Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl left review comments

Assignees
No one assigned
Labels
replace replace method Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: "replace" does not work with different numpy-int types even when values are the same
4 participants
@weikhor @pep8speaks @phofl @jreback