BUG: Frame.iat item_cache invalidation bug #45706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jbrockmendel
commented
Jan 30, 2022
•
jbrockmendel
commented
- closes BUG: Label and integer based indexing return different values for same column #45684
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
phofl
reviewed
Jan 30, 2022
mroeschke
added
the
Indexing
jreback
requested changes
Jan 30, 2022
doc/source/whatsnew/v1.5.0.rst
Outdated
| @@ -268,6 +268,7 @@ Indexing | |||
| - Bug in :meth:`Series.__setitem__` where setting :attr:`NA` into a numeric-dtpye :class:`Series` would incorrectly upcast to object-dtype rather than treating the value as ``np.nan`` (:issue:`44199`) | |||
| - Bug in :meth:`DataFrame.mask` with ``inplace=True`` and ``ExtensionDtype`` columns incorrectly raising (:issue:`45577`) | |||
| - Bug in getting a column from a DataFrame with an object-dtype row index with datetime-like values: the resulting Series now preserves the exact object-dtype Index from the parent DataFrame (:issue:`42950`) | |||
| - Bug in :meth:`DataFrame.iat` setting values leading to not propagating correctly in subsequent lookups (:issue:`45684`) | |||
|
updated + green |
jreback
approved these changes
Jan 30, 2022
|
@meeseeksdev backport 1.4.x |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@jbrockmendel if you can push the manual backport here |
jbrockmendel
added a commit
to jbrockmendel/pandas
that referenced
this pull request
Jan 31, 2022
jreback
pushed a commit
that referenced
this pull request
Feb 1, 2022
phofl
pushed a commit
to phofl/pandas
that referenced
this pull request
Feb 14, 2022
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.