Simplify conditional branch in _read function in readers.py #45696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Compro-Prasad
commented
Jan 29, 2022
•
Compro-Prasad
commented
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
Compro-Prasad
force-pushed
the
simplify-_read
branch
from
7cdcac0 to
14ab558
Compare
phofl
reviewed
Jan 30, 2022
Compro-Prasad
force-pushed
the
simplify-_read
branch
from
14ab558 to
03e29b1
Compare
mroeschke
approved these changes
Jan 30, 2022
phofl
approved these changes
Jan 30, 2022
|
thx @Compro-Prasad |
phofl
pushed a commit
to phofl/pandas
that referenced
this pull request
Feb 14, 2022
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.