Skip to content

TST: Remove unused fixtures #45692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 30, 2022
Merged

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke commented Jan 29, 2022

  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them

@mroeschke mroeschke added the Testing pandas testing functions or related to the test suite label Jan 29, 2022
@mroeschke mroeschke added this to the 1.5 milestone Jan 29, 2022
@jbrockmendel
Copy link
Member

Looks like recent commits are trial/error for [something]. If thats sorted out ill take a look, tentatively looks good.

@mroeschke
Copy link
Member Author

Looks like recent commits are trial/error for [something]. If thats sorted out ill take a look, tentatively looks good.

This was an attempt at fixing https://github.com/pandas-dev/pandas/runs/4992372435?check_suite_focus=true but I cant reproduce locally

@mroeschke
Copy link
Member Author

Ready for another look

@jbrockmendel jbrockmendel merged commit f46df09 into pandas-dev:main Jan 30, 2022
@jbrockmendel
Copy link
Member

thanks @mroeschke

@mroeschke mroeschke deleted the tst/unused_fixtures branch January 30, 2022 18:12
phofl pushed a commit to phofl/pandas that referenced this pull request Feb 14, 2022
* TST: Remove unused fixtures

* Undo a removed fixture

* Add back other fixtures

* Undo a file

* Try undoing this?

* Revert "Try undoing this?"

This reverts commit 0e56cb0.
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
* TST: Remove unused fixtures

* Undo a removed fixture

* Add back other fixtures

* Undo a file

* Try undoing this?

* Revert "Try undoing this?"

This reverts commit 0e56cb0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants