Adding DuckDB as a SQL Database for the to_sql() function #45675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks for the PR, DuckDb looks interesting. Might be worth opening an issue + getting agreement from core team that this is something we want to support before continuing dev here |
mroeschke
requested changes
Jan 28, 2022
There was a problem hiding this comment.
I commented on your created issue as well, but noted in #45678 (comment) that it would be great to have a SQL engine interface to implement Duck DB instead of having Duck DB specific code here
|
agree with @mroeschke recommendations here. |
|
Thanks for the pull request, but as mentioned, in #45678 (comment), pandas would need to support a DB engine interface first before supporting DuckDB directly. Closing for now, but happy to have progress on the interface! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds DuckDB as a direct possibility to the to_sql() function.
It basically uses DuckDBs internal pandas integration to load data frames as a duckdb table.
I think I've added duckdb correctly as an optional dependency, I'm happy to fix it if I made any mistake :-)
I'm also really supporting the optional
if_existsattribute, if any other attribute is a 'must-have' I'm also happy to do so.