BUG: unnecessary FutureWarning in sort_values #45668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jbrockmendel
commented
Jan 28, 2022
jbrockmendel
commented
- closes BUG: passing a SparseArray to pd.Index - overly eager FutureWarning #45618
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
jreback
reviewed
Jan 28, 2022
|
hmm failing tests though |
yah places where we are testing for futurewarning and no longer getting them. will update. |
updated + greenishx |
mroeschke
reviewed
Jan 30, 2022
doc/source/whatsnew/v1.4.1.rst
Outdated
| @@ -28,6 +28,7 @@ Fixed regressions | |||
| Bug fixes | |||
| ~~~~~~~~~ | |||
| - Fixed segfault in :meth:``DataFrame.to_json`` when dumping tz-aware datetimes in Python 3.10 (:issue:`42130`) | |||
| - Stopped emitting unnecessary ``FutureWarning`` in :meth:`DataFrame.sort_values` with sparse columns (:issue:`45618``) | |||
There was a problem hiding this comment.
Nit: Extra backtick at the end of the issue number
There was a problem hiding this comment.
good catch, will update
mroeschke
approved these changes
Jan 30, 2022
|
@meeseeksdev backport 1.4.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jan 30, 2022
|
Something went wrong ... Please have a look at my logs. |
jreback
pushed a commit
that referenced
this pull request
Jan 31, 2022
…5727) Co-authored-by: jbrockmendel <[email protected]>
phofl
pushed a commit
to phofl/pandas
that referenced
this pull request
Feb 14, 2022
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.