Skip to content

Backport PR #45627 on branch 1.4.x (CLN: Use pytest -r to show skipped tests instead of print_skipped.py) #45645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/assign.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,10 @@ on:
types: created

jobs:
one:
issue_assign:
runs-on: ubuntu-latest
steps:
- if: github.event.comment.body == 'take'
name:
run: |
echo "Assigning issue ${{ github.event.issue.number }} to ${{ github.event.comment.user.login }}"
curl -H "Authorization: token ${{ secrets.GITHUB_TOKEN }}" -d '{"assignees": ["${{ github.event.comment.user.login }}"]}' https://api.github.com/repos/${{ github.repository }}/issues/${{ github.event.issue.number }}/assignees
3 changes: 0 additions & 3 deletions .github/workflows/datamanger.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,3 @@ jobs:
run: |
source activate pandas-dev
ci/run_tests.sh

- name: Print skipped tests
run: python ci/print_skipped.py
7 changes: 1 addition & 6 deletions .github/workflows/docbuild-and-upload.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,7 @@ jobs:
- name: Build documentation
run: |
source activate pandas-dev
doc/make.py --warnings-are-errors | tee sphinx.log ; exit ${PIPESTATUS[0]}

# This can be removed when the ipython directive fails when there are errors,
# including the `tee sphinx.log` in te previous step (https://github.com/ipython/ipython/issues/11547)
- name: Check ipython directive errors
run: "! grep -B10 \"^<<<-------------------------------------------------------------------------$\" sphinx.log"
doc/make.py --warnings-are-errors

- name: Install ssh key
run: |
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/posix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -150,9 +150,6 @@ jobs:
path: test-data.xml
if: failure()

- name: Print skipped tests
run: python ci/print_skipped.py

- name: Upload coverage to Codecov
uses: codecov/codecov-action@v2
with:
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/python-dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,6 @@ jobs:
path: test-data.xml
if: failure()

- name: Print skipped tests
run: |
python ci/print_skipped.py

- name: Report Coverage
run: |
coverage report -m
Expand Down
5 changes: 0 additions & 5 deletions ci/azure/posix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,3 @@ jobs:
testResultsFiles: 'test-data.xml'
testRunTitle: ${{ format('{0}-$(CONDA_PY)', parameters.name) }}
displayName: 'Publish test results'

- script: |
source activate pandas-dev
python ci/print_skipped.py
displayName: 'Print skipped tests'
5 changes: 0 additions & 5 deletions ci/azure/windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,3 @@ jobs:
testResultsFiles: 'test-data.xml'
testRunTitle: ${{ format('{0}-$(CONDA_PY)', parameters.name) }}
displayName: 'Publish test results'

- bash: |
source activate pandas-dev
python ci/print_skipped.py
displayName: 'Print skipped tests'
38 changes: 0 additions & 38 deletions ci/print_skipped.py

This file was deleted.

2 changes: 1 addition & 1 deletion ci/run_tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ if [[ $(uname) == "Linux" && -z $DISPLAY ]]; then
XVFB="xvfb-run "
fi

PYTEST_CMD="${XVFB}pytest -m \"$PATTERN\" -n $PYTEST_WORKERS --dist=loadfile $TEST_ARGS $COVERAGE $PYTEST_TARGET"
PYTEST_CMD="${XVFB}pytest -r fEs -m \"$PATTERN\" -n $PYTEST_WORKERS --dist=loadfile $TEST_ARGS $COVERAGE $PYTEST_TARGET"

if [[ $(uname) != "Linux" && $(uname) != "Darwin" ]]; then
PYTEST_CMD="$PYTEST_CMD --ignore=pandas/tests/plotting/"
Expand Down