Skip to content

BUG: frame.shift(axis=1) with ArrayManager #45644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 30, 2022

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just needs a whatsnew note.

@mroeschke mroeschke added ArrayManager DataFrame DataFrame data structure labels Jan 30, 2022
@jbrockmendel
Copy link
Member Author

Just needs a whatsnew note

should only affect ArrayManager, which isn't public/documented.

@mroeschke mroeschke added this to the 1.5 milestone Jan 30, 2022
@jreback
Copy link
Contributor

jreback commented Jan 30, 2022

still don't reallly like this code path but ok. ping on green.

@jbrockmendel
Copy link
Member Author

ping

@jreback jreback merged commit ae67cb7 into pandas-dev:main Jan 30, 2022
@jbrockmendel jbrockmendel deleted the ref-shift-mgr branch January 31, 2022 00:08
phofl pushed a commit to phofl/pandas that referenced this pull request Feb 14, 2022
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DataFrame DataFrame data structure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants