Skip to content

REGR: loc.setitem losing index name when df was empty before #45623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 26, 2022
Merged

REGR: loc.setitem losing index name when df was empty before #45623

merged 3 commits into from
Jan 26, 2022

Conversation

phofl
Copy link
Member

@phofl phofl commented Jan 25, 2022 •
edited
Loading

@phofl phofl added Indexing Related to indexing on series/frames, not to indexes themselves Regression Functionality that used to work in a prior pandas version labels Jan 25, 2022
@phofl phofl added this to the 1.4.1 milestone Jan 25, 2022
jreback
jreback requested changes Jan 26, 2022
View reviewed changes
pandas/core/indexing.py Outdated
@@ -2018,6 +2018,8 @@ def _setitem_with_indexer_missing(self, indexer, value):
# internals.concat logic
df = value.to_frame().T
df.index = [indexer]
# error: "List[Any]" has no attribute "name"
df.index.name = self.obj.index.name # type: ignore[attr-defined]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm this is actually modifying the indexer i think.

maybe
df.index = pd.Index([indexer], name=self.obj.index.name)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, changed

@jreback jreback merged commit 3aa2ed4 into pandas-dev:main Jan 26, 2022
@meeseeksmachine meeseeksmachine mentioned this pull request Jan 26, 2022
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jan 26, 2022
@phofl @meeseeksmachine
Backport PR pandas-dev#45623: REGR: loc.setitem losing index name whe…
1e9bce2 
…n df was empty before
jreback pushed a commit that referenced this pull request Jan 27, 2022
@meeseeksmachine @phofl
Backport PR #45623: REGR: loc.setitem losing index name when df was e…
a225499 
…mpty before (#45650)

Co-authored-by: Patrick Hoefler <[email protected]>
@phofl phofl deleted the 45621 branch January 28, 2022 10:19
@simonjayhawkins simonjayhawkins mentioned this pull request Mar 12, 2022
Closed
3 tasks
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@phofl @yehoshuadimarsky
REGR: loc.setitem losing index name when df was empty before (pandas-…
f65b693 
…dev#45623)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback requested changes

Assignees
No one assigned
Labels
Indexing Related to indexing on series/frames, not to indexes themselves Regression Functionality that used to work in a prior pandas version
Projects
None yet
Milestone
1.4.1
Development

Successfully merging this pull request may close these issues.

BUG: 1.4.0 does not preserve initially empty Index and appended by loc assignment.
2 participants
@phofl @jreback