-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
BUG: fix skiprows callable infinite loop #45586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
3f8f7c6
BUG: fix skiprows callable infinite loop
bram2000 e563d93
BUG: seperate new test
bram2000 0e09f5a
add whatsnew entry
bram2000 30cfec6
make note user-centric
bram2000 831f69c
add engine
bram2000 ac235d4
move note to IO section
bram2000 9df6e01
modify comment
bram2000 c1acd08
Merge branch 'main' into skiprows-function-fix
jreback 85d5ee1
add test for csv
bram2000 a1f9187
lint
bram2000 3e41e7d
formatting
bram2000 196b055
fix whatsnew
bram2000 3abc40a
test not valid for pyxlsb
bram2000 ecd25b9
Merge branch 'main' into skiprows-function-fix
bram2000 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does engine=python mean? I do not think that python is valid. Please also add ticks around the string, e.g.
engine="python"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure it was suggested here #45586 (comment)
I've just removed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please let the reviewer resolve conversations
I think I get what jeff meant.
read_csv with engine="python" and read_excel
.Please also add a test for read_csv