Skip to content

REF: avoid upcast/downcast in Block.where #45582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 30, 2022
Merged

REF: avoid upcast/downcast in Block.where #45582

merged 10 commits into from
Jan 30, 2022

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

Puts us within a stone's throw of being able to share Block.where with EABackedBlock.where.

@jreback jreback added Dtype Conversions Unexpected or buggy dtype conversions Internals Related to non-user accessible pandas implementation Refactor Internal refactoring of code labels Jan 27, 2022
@jreback jreback added this to the 1.5 milestone Jan 27, 2022
@jbrockmendel jbrockmendel mentioned this pull request Jan 29, 2022
Merged
4 tasks
@jreback jreback merged commit e92839e into pandas-dev:main Jan 30, 2022
@jbrockmendel jbrockmendel deleted the ref-share-more branch January 31, 2022 00:10
phofl pushed a commit to phofl/pandas that referenced this pull request Feb 14, 2022
@jbrockmendel @phofl
REF: avoid upcast/downcast in Block.where (pandas-dev#45582)
7f3ac91
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@jbrockmendel @yehoshuadimarsky
REF: avoid upcast/downcast in Block.where (pandas-dev#45582)
44f0a19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback left review comments

Assignees
No one assigned
Labels
Dtype Conversions Unexpected or buggy dtype conversions Internals Related to non-user accessible pandas implementation Refactor Internal refactoring of code
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback