Skip to content

DEPR: treating float data as wall-times in DTA._from_sequence #45573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 19, 2022
Merged

DEPR: treating float data as wall-times in DTA._from_sequence #45573

merged 7 commits into from
Feb 19, 2022

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@mroeschke mroeschke added the Deprecate Functionality to remove in pandas label Jan 26, 2022
@mroeschke mroeschke added this to the 1.5 milestone Jan 26, 2022
@mroeschke
Copy link
Member

Oops looks like this one slipped through the cracks. Care to merge main one more time?

@mroeschke mroeschke mentioned this pull request Feb 15, 2022
Closed
mroeschke
mroeschke approved these changes Feb 15, 2022
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Think it's okay to merge on greenish

@jbrockmendel
Copy link
Member Author

green

@mroeschke mroeschke merged commit 2a4c9df into pandas-dev:main Feb 19, 2022
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the depr-floats-to-dates branch February 19, 2022 03:00
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@jbrockmendel @yehoshuadimarsky
DEPR: treating float data as wall-times in DTA._from_sequence (pandas…
46f4841 
…-dev#45573)

* DEPR: treating float data as wall-times in DTA._from_sequence

* GH refs

* mypy fixup

* lint fixup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @mroeschke