ENH: Experimental Higher Order Methods API #45557
Conversation
|
Might wait until Monday to take a look. Troubleshooting azure left me cranky. |
|
@jreback @jbrockmendel friendly ping. |
| result = getattr(self.obj, method)(a) | ||
| except (TypeError, DataError): | ||
| warnings.warn( | ||
| f"{name} did not aggregate successfully. If any error is " |
There was a problem hiding this comment.
why do we want to warn here? (e.g. new api can we just raise)
There was a problem hiding this comment.
Right - new API will just raise. Starting out, I'd like to maintain as much consistency between api.use_hom=True and api.use_hom=False as possible, only making changes that would be hard/impossible to properly deprecate. Since this is already deprecated and will be changed in 2.0, I don't see a need to do it here.
doc/source/user_guide/homs_api.rst
Outdated
|
|
||
| pandas is experimenting with improving the behavior of higher order methods (HOMs). These | ||
| are methods that take a function as an argument, often a user-defined function (UDF). | ||
| They include ``.apply``, ``.agg``, ``.transform``, and ``.filter``. The goal is to make |
There was a problem hiding this comment.
certainly could be done in followups
- link to the doc-strings for these methods
- in the doc-strings show the behavior changes when
use_homis enabled.
There was a problem hiding this comment.
Will link to doc strings here; going to hold off modifying the public doc-strings until this is ready.
There was a problem hiding this comment.
Done. I only listed methods that are currently being modified when using api.use_hom=True. Will expand the list as modifications occur.
|
|
||
| if not self.as_index: | ||
| self._insert_inaxis_grouper_inplace(result) | ||
| result.index = Index(range(len(result))) |
There was a problem hiding this comment.
some of this looks familiar. is it as de-duplicated as it can reasonably get?
There was a problem hiding this comment.
Perhaps not, but will be changed when implementing "agg always aggs" (#35725). In other words, duplicating further will likely have to be undone in the future.
Start of #41112, second attempt at #43736.
Built docs can be viewed in #43736 (wording slightly changed from there, but results are the same). If we go forward with this approach, needs to run on the CI with failures allowed.
cc @jbrockmendel