BUG: df.getitem returning copy instead of view for unique column in dup index #45526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Copy / view semantics
Indexing
|
perf impact? |
Good point. Let's check for uniqueness or that the key is unique, so we only have the drop duplicates call if we have non unique columns |
# Conflicts: # doc/source/whatsnew/v1.5.0.rst
jreback
requested changes
Feb 26, 2022
|
@phofl can you merge master and some comments |
|
Done |
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
Merged master again |
|
@phofl could you merge in one more time. Looks pretty good. |
� Conflicts: � pandas/tests/indexing/test_chaining_and_caching.py
|
Done |
jreback
approved these changes
Jun 22, 2022
|
thanks @phofl very nice as always |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is more intuitive (and "more" correct) than the previous behavior.