Skip to content

get_dummies to select string dtype in addition to object and categorical #45516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 28, 2022

Conversation

lukemanley
Copy link
Member

@lukemanley lukemanley commented Jan 21, 2022

Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a whatsnew?

@lukemanley
Copy link
Member Author

Sure - would this go under Bug Fixes > Strings or Other enhancements?

@phofl
Copy link
Member

phofl commented Jan 21, 2022

Would put it under bug fixes

@NumberPiOso
Copy link
Contributor

Should a test that uses df = df.convert_dtypes() be added? #44965

@jreback jreback added Bug Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Jan 28, 2022
@jreback jreback added this to the 1.5 milestone Jan 28, 2022
@jreback jreback merged commit 579ec33 into pandas-dev:main Jan 28, 2022
@jreback
Copy link
Contributor

jreback commented Jan 28, 2022

thanks @lukemanley

@lukemanley lukemanley deleted the get-dummies-string-dtype branch March 2, 2022 01:13
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Apply pd.get_dummies() on string type columns of pandas dataframe do nothing?
4 participants