TST: Add test inconsistency in group by (#44803) #45509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Jan 20, 2022
mroeschke
added
the
Testing
|
The code fails one test, but the test it's named pytest (actions-310-numpydev.yaml, not slow and not network, xclip, deprecate, -W error). Can someone help me with the error? |
|
The failure is unrelated. Could you merge main again? |
|
Done ! |
|
thanks @NumberPiOso |
jreback
reviewed
Jan 23, 2022
| @@ -32,6 +32,20 @@ | |||
| from pandas.core.groupby.base import maybe_normalize_deprecated_kernels | |||
|
|
|||
|
|
|||
| def test_group_by_copy(): | |||
There was a problem hiding this comment.
hmm actually should be in pandas/tests/groupby/test_apply_mutate.py
@NumberPiOso if you wouldn't mind doing a PR to move this.
There was a problem hiding this comment.
Yes! , PR#45578
NumberPiOso
added a commit
to NumberPiOso/pandas
that referenced
this pull request
Jan 23, 2022
Pending tasks from pandas-dev#45509 In line with issue pandas-dev#44803
NumberPiOso
added a commit
to NumberPiOso/pandas
that referenced
this pull request
Jan 23, 2022
Pending tasks from pandas-dev#45509 In line with issue pandas-dev#44803 Change test_groupby_copy from `pandas/tests/groupby/test_groupby.py` to `pandas/tests/groupby/test_apply_mutate.py`
1 task
mroeschke
pushed a commit
that referenced
this pull request
Jan 24, 2022
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Pending tasks from pandas-dev#45509 In line with issue pandas-dev#44803 Change test_groupby_copy from `pandas/tests/groupby/test_groupby.py` to `pandas/tests/groupby/test_apply_mutate.py`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
groupby.apply()inconsistently indexes its return value with the groupby-cols #44803