-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: Boxplots ignore xlabel and boxplot() doesn't support horizontal layout #45465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stefmolin
commented
Jan 19, 2022
•
edited
Loading
edited
- closes BUG: Horizontal boxplots on subplots throws ValueError #36918 and closes BUG: Boxplots are ignoring xlabel #45463
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
mroeschke
reviewed
Jan 19, 2022
mroeschke
reviewed
Jan 19, 2022
mroeschke
reviewed
Jan 19, 2022
mroeschke
approved these changes
Jan 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@stefmolin could you merge in the main branch once more? We had CI issues this past week |
mroeschke
approved these changes
Jan 24, 2022
Thanks @stefmolin |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
…layout (pandas-dev#45465) * BUG: Fix support for xlabel/ylabel in boxplots. * TST: Add tests for checking boxplot axis labels. * DOC: Update whatsnew 1.5.0 * CLN: Add comments pointing to PR for changes. * CLN: Default vert to True in get(). * TST: Split new test into 3 distinct tests. * CLN: Move pprint_thing() import near other pandas imports. * CLN: Linting. * CLN: Add trailing comma to tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.