-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CI: Don't split slow vs non slow jobs for GHA posix #45437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this needed? |
Yup this is an orthogonal cleanup. |
All good here. Failure unrelated. |
@mroeschke needs a rebase |
@mroeschke one more rebase if you can and https://github.com/pandas-dev/pandas/runs/4932326914?check_suite_focus=true failed (but looks suprios) |
@meeseeksdev backport 1.4.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jan 25, 2022
Something went wrong ... Please have a look at my logs. |
jreback
pushed a commit
that referenced
this pull request
Jan 25, 2022
…ix (#45620) Co-authored-by: Matthew Roeschke <[email protected]>
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since GHA has a 6 hour job limit, and it appears that slow jobs take ~25 mins and non-slow jobs take ~35 minutes, it shouldn't be necessary to split these anymore.
Helps reduce the number of builds so more can run concurrently.