BUG: BooleanArray+pd.NA altering array inplace #45421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jbrockmendel
commented
Jan 17, 2022
jbrockmendel
commented
- closes #xxxx
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
jorisvandenbossche
requested changes
Jan 18, 2022
| @@ -83,6 +83,18 @@ def test_op_int8(left_array, right_array, opname): | |||
| tm.assert_extension_array_equal(result, expected) | |||
|
|
|||
|
|
|||
| def test_boolean_array_add_pdna(): | |||
There was a problem hiding this comment.
Maybe can move this test to arrays/masked/test_arithmetic.py to have it for the integer and floating dtypes at the same time as well (those don't have this bug, but I don't directly see a test for it)
jorisvandenbossche
approved these changes
Jan 19, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.