Skip to content

STYLE: use option_context almost always #45407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2022

Conversation

chrismoradi
Copy link
Contributor

@chrismoradi chrismoradi commented Jan 17, 2022

Replaces set_option except when this function is directly tested.

Happy to revisit/revise if I missed anything. Thanks!

Replaces `set_option` except when this function is directly tested.

Closes: pandas-dev#38813
@jreback jreback added the Code Style Code style, linting, code_checks label Jan 17, 2022
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, ping on greenish

@chrismoradi
Copy link
Contributor Author

@jreback, trying to understand if there's an actual failure here or just a timeout with Azure (and I don't see an option to retry). If you can point me to an error in the pr, I'd be happy to fix it.

@jreback jreback added this to the 1.5 milestone Jan 17, 2022
@jreback
Copy link
Contributor

jreback commented Jan 17, 2022

thanks @chrismoradi

@jreback jreback merged commit 2e5b05e into pandas-dev:main Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

STYLE: use option_context almost always
2 participants