Skip to content

TST: xfail test_arrowparquet_options for windows #45354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 14, 2022
Merged

TST: xfail test_arrowparquet_options for windows #45354

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f74365e
TST: xfail test_arrowparquet_options for windows
mroeschke Jan 13, 2022
ce23c8c
Add direct import
mroeschke Jan 13, 2022
dd98618
Mark as 3.8 only
mroeschke Jan 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pandas/tests/io/test_fsspec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import numpy as np
import pytest

from pandas.compat import is_platform_windows
from pandas.compat._optional import VERSIONS

from pandas import (
Expand Down Expand Up @@ -161,6 +162,7 @@ def test_to_parquet_new_file(monkeypatch, cleared_fs):


@td.skip_if_no("pyarrow")
@pytest.mark.xfail(is_platform_windows(), reason="GH 45344")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this failing all builds or should be strict=False?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yah looks like it xpassed on one of the builds here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I added a terse check for only PY38 so I could avoid strict=False

def test_arrowparquet_options(fsspectest):
"""Regression test for writing to a not-yet-existent GCS Parquet file."""
df = DataFrame({"a": [0]})
Expand Down