Skip to content

BUG: pd.to_datetime([np.str_ objects]) GH#32264 #45280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2022
Merged

BUG: pd.to_datetime([np.str_ objects]) GH#32264 #45280

merged 1 commit into from
Jan 10, 2022

Conversation

jbrockmendel
Copy link
Member

mroeschke
mroeschke approved these changes Jan 9, 2022
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Probably need to parameterize tests over np.str_ at some point. Guessing there's a lot more of these cases.

@mroeschke mroeschke added this to the 1.5 milestone Jan 9, 2022
@mroeschke mroeschke added the Datetime Datetime data dtype label Jan 9, 2022
@jreback
Copy link
Contributor

jreback commented Jan 10, 2022

yeah agree we likley need a generic conversion function where we can use everywhere we accept strings

@jreback jreback merged commit 5940f15 into pandas-dev:master Jan 10, 2022
@jbrockmendel jbrockmendel deleted the bug2 branch January 10, 2022 16:23
@MarcoGorelli MarcoGorelli mentioned this pull request Oct 6, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Datetime Datetime data dtype
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

[to_datetime] TypeError: Argument 'date_string' has incorrect type (expected str, got numpy.str_)
3 participants
@jbrockmendel @jreback @mroeschke